Helm namespace mirroring #1601
Merged
Helm namespace mirroring #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-eckert
force-pushed
the
helm-namespace-mirroring
branch
from
1519e37
to
6e9c0a7
Compare
t-eckert
commented
Oct 7, 2022
| @@ -1,6 +1,5 @@ | |||
| {{- if and .Values.global.peering.enabled (not .Values.connectInject.enabled) }}{{ fail "setting global.peering.enabled to true requires connectInject.enabled to be true" }}{{ end }} | |||
| {{- if (or (and (ne (.Values.connectInject.enabled | toString) "-") .Values.connectInject.enabled) (and (eq (.Values.connectInject.enabled | toString) "-") .Values.global.enabled)) }} | |||
| {{- if and .Values.connectInject.consulNamespaces.mirroringK8S (not .Values.global.enableConsulNamespaces) }}{{ fail "global.enableConsulNamespaces must be true if mirroringK8S=true" }}{{ end }} | |||
There was a problem hiding this comment.
Instead of failing here, I have the enable mirroring flag check for both conditions to be true in order to be passed to inject-connect.
t-eckert
commented
Oct 7, 2022
|
|
||
| local actual=$(echo $object | | ||
| yq 'any(contains("k8s-namespace-mirroring-prefix"))' | tee /dev/stderr) | ||
| [ "${actual}" = "false" ] | ||
| } | ||
|
|
||
| @test "connectInject/Deployment: mirroring options set with .connectInject.consulNamespaces.mirroringK8S=true" { | ||
| @test "connectInject/Deployment: mirroring options omitted with .connectInject.consulNamespaces.mirroringK8S=false" { |
There was a problem hiding this comment.
The condition this checked is now covered by the test on line 681. I changed it to check the opposite case as it is no longer the default behavior.
added 6 commits
October 7, 2022 18:38
…oringK8S` to `true`
t-eckert
force-pushed
the
helm-namespace-mirroring
branch
from
6e9c0a7
to
f908106
Compare
thisisnotashwin
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
syncCatalog.consulNamespaces.mirroringK8Snow defaults totrueconnectInject.consulNamespaces.mirroringK8Snow defaults totrueconnectInject.consulNamespaces.mirrorK8S=trueandglobal.enableConsulNamespaces=false, theconnect-inject-deployment.yamltemplate instead checks for both to be true in order to pass the-enable-k8s-namespace-mirroring=trueflag. That means,connectInject.consulNamespaces.mirrorK8S=trueandglobal.enableConsulNamespaces=falseis now a valid deployment configuration that will simply not tell Consul to perform mirroring given that Consul namespaces is nottrue.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: